search

avendesora / pythonbible

A python library for validating, parsing, normalizing scripture references and retrieving scripture texts (for open source and public domain versions)
https://docs.python.bible
MIT License
60 stars 12 forks source link

ASV data has incomplete bible #89

Closed rswhiting closed 1 year ago

rswhiting commented 1 year ago

In pythonbible/bible/data/asv/verses.json only the first line of each verse exists. For example, Psalm 1:1 (19001001) only contains "Blessed is the man that walketh not in the counsel of the wicked," and not the full "Blessed is the man that walketh not in the counsel of the wicked, Nor standeth in the way of sinners, Nor sitteth in the seat of scoffers: "

I suspect this is due to the newlines in the poetic or multi-line verses. This is a pretty major issue because large chunks of the bible are missing with no indication that something failed. To be clear: this is a data storage issue, not a problem with the code itself.

avendesora commented 1 year ago

That is a major issue. Thanks for pointing it out. The next release of pythonbible, which should be coming out this month (possibly this week), is completely changing how that data is stored and used; and, thankfully, it seems to have resolved this particular issue. I wouldn't recommend using it yet as it's still being tested, but if you want to take a look, you can see the code for the next release in this pull request: https://github.com/avendesora/pythonbible/pull/86

Thanks again for letting me know about this issue. I'm trying to formulate a plan for thoroughly testing the accuracy of the storing/formatting/displaying of all the scripture text. I'll definitely need to have that level of testing before the 1.0 release of pythonbible.

rswhiting commented 1 year ago

I discovered this repo, and it may be useful to just take their json or xml (they have a mysql option that I'm currently pursuing). The project I'm working on may also benefit from their cross-references db table.

avendesora commented 1 year ago

Thanks, I'll definitely check it out. Some sort of support for cross-references is on the roadmap (date/release TBD) for pythonbible as well, so I'll add this as a potential resource for that project.