avengerx
commented
1 year ago Fixed by completely reworking the code. There are still some minor aspects to correct, but at the moment it pretty much works fine in applications that use the effect.
The direction issue was fixed by completely removing the related code. Now big/small actuators are identified by their binary code sent as axis identifier. I don't know where applications are finding the actuators, but they are querying the download function without passing either object type (ids/offsets), but only coordinate system (cartesian; sometimes polar; spherical is reported as unsupported by the joystick OEM DIEFFECTATTRIBUTES).
Related commits:
- 2fd6719db3c52abd48bf78a9d4beb19f08fd00cf (enables permanent effects)
- bd153a9f0fb88b3d521ccb5e5a4267322c276255 (reviews overall logic)
- 3a2aa5c6cfb8476c2a2d82955593d3d20dfdc4a4 (ensured forces between 0 and 254)
- 6856a26d01fd2abbbf36846e877b70f0465d2dcb (adds macros with OEM values)
- 0906cf7c5599924dbbf18194d4559c27b931795d (reviews to StartEffect=>EnqueueEffect)
- 3f35a2e296976e9f29300f7f8ec6a6ecd80a9170 (joins forceX/Y in a single value, later undone to favor the small/big motor naming),
- e2d15f3d23f5eb5f2c7ff29096ca0be0ab5ea089 (adds support to force's gain parameter),
- 395f774d47619eb214778c65c152edd4f8f56317 (review parameters to resemble MS documentation parameter names)
- e72d616046d90fbaf28f382e6c161fbc0b9433ee (reimplements small/big actuator support by properly identifying when they are passed and preserving the other if updating the effect)
The ConstantForce effect doesn't seem to conform to MS documentation as for ranges and its feedback.
Also, if direction is
0, no vibration happens, no matter how the force is set.