averbis / averbis-python-api

Conveniently access the REST API of Averbis products using Python
Apache License 2.0
12 stars 4 forks source link

Issue #134: Export as CAS: only get document id if really necessary #135

Closed UWinch closed 1 year ago

UWinch commented 1 year ago

What is in the PR?

During CAS export for a document, only get the document identifer if really necessary i.e. the typesystem is not supplied and/or an older product version is used.

How to test manually

Check that the CAS export still works.

codecov-commenter commented 1 year ago

Codecov Report

Merging #135 (425fdef) into dev (234196f) will decrease coverage by 0.08%. The diff coverage is 60.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #135      +/-   ##
==========================================
- Coverage   92.24%   92.16%   -0.08%     
==========================================
  Files          16       16              
  Lines        2167     2171       +4     
==========================================
+ Hits         1999     2001       +2     
- Misses        168      170       +2     
Impacted Files Coverage Δ
averbis/core/_rest_client.py 86.62% <60.00%> (-0.14%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more