search

averbis / averbis-python-api

Conveniently access the REST API of Averbis products using Python
Apache License 2.0
12 stars 4 forks source link

Issue #38: Implement endpoints related to Processes #39

Closed nadre closed 3 years ago

nadre commented 3 years ago

This pull request contains the implementation of the new endpoints as described in Issue #38

Philly-B commented 3 years ago

Test

reckart commented 3 years ago

Please run "make black" for auto-formatting.

reckart commented 3 years ago

I have changed the target branch from main to dev - PRs should go to dev. Main should always be the latest release version... I also make the mistake sometimes.... we need to pay attention.

Can you please merge the latest change from dev into your branch, resolve conflicts, make black and then re-request the review. Thanks!

codecov-commenter commented 3 years ago

Codecov Report

Merging #39 (d3a89ee) into dev (7f117a3) will increase coverage by 1.17%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #39      +/-   ##
==========================================
+ Coverage   87.85%   89.03%   +1.17%     
==========================================
  Files          14       15       +1     
  Lines        1153     1277     +124     
==========================================
+ Hits         1013     1137     +124     
  Misses        140      140
Impacted Files Coverage Δ
averbis/core/__init__.py 100.00% <ø> (ø)
averbis/highlighting/_utils.py 93.10% <ø> (ø)
averbis/__init__.py 100.00% <100.00%> (ø)
averbis/core/_rest_client.py 82.36% <100.00%> (+1.90%) :arrow_up:
tests/test_process.py 100.00% <100.00%> (ø)
tests/test_project.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f117a3...d3a89ee. Read the comment docs.

nadre commented 3 years ago

@reckart & @Philly-B I think I'm done here. Please check and merge if everything's fine.

reckart commented 3 years ago

@Philly-B fine by me - would you like to give a thumbs up as well and merge?