search

averbis / averbis-python-api

Conveniently access the REST API of Averbis products using Python
Apache License 2.0
12 stars 4 forks source link

Feature/robust URLs #40

Closed Philly-B closed 3 years ago

Philly-B commented 3 years ago

The Client is not robust against a trailing slash in the URL. The double slash leads to a 500 exception (which of cause should not happen by the platform but still this error can be prevented).

codecov-commenter commented 3 years ago

Codecov Report

Merging #40 (b415704) into dev (9578e8a) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #40      +/-   ##
==========================================
+ Coverage   89.03%   89.07%   +0.04%     
==========================================
  Files          15       15              
  Lines        1277     1282       +5     
==========================================
+ Hits         1137     1142       +5     
  Misses        140      140
Impacted Files Coverage Δ
averbis/core/_rest_client.py 82.41% <100.00%> (+0.05%) :arrow_up:
tests/test_client.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9578e8a...b415704. Read the comment docs.

reckart commented 3 years ago

Thanks :)

Please open issues before submitting a PR and use the issue number and issue title in the commit comments. I still need to write contribution guidelines...