averbis / averbis-python-api

Conveniently access the REST API of Averbis products using Python
Apache License 2.0
12 stars 4 forks source link

Issue #60: Improving error messages #67

Closed DavidHuebner closed 3 years ago

DavidHuebner commented 3 years ago
codecov-commenter commented 3 years ago

Codecov Report

Merging #67 (b7b7829) into dev (318fa9c) will decrease coverage by 0.08%. The diff coverage is 92.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #67      +/-   ##
==========================================
- Coverage   90.12%   90.04%   -0.09%     
==========================================
  Files          15       15              
  Lines        1388     1437      +49     
==========================================
+ Hits         1251     1294      +43     
- Misses        137      143       +6     
Impacted Files Coverage Δ
averbis/core/_rest_client.py 83.93% <89.61%> (-0.34%) :arrow_down:
tests/test_client.py 100.00% <100.00%> (ø)
tests/test_project.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 318fa9c...b7b7829. Read the comment docs.

nadre commented 3 years ago

Nice job @DavidHuebner! I skimmed over the changes and couldn't see any problems but I'll leave the merge to @reckart.