averbraeck / housinggame-facilitator

Facilitator app for the housing game
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Flood table flipped pluvial and fluvial labels #24

Closed averbraeck closed 10 months ago

averbraeck commented 10 months ago

Top table numbers are different from bottom table ones.

image

averbraeck commented 10 months ago

Calculation is correct now. It turned out to be really, really complicated. One the one hand the community protection levels per round change as a result of NewsEffects, while on the other hand the discount of houses is introduced in a round. When either of these methods are introduced, floods might already have occurred, and could even have been superseded by new floods (that would not have been a flood before the NewsEffects changes). The first discount takes effect the round after the flooding happened.

The results look, e.g. as follows table has also been made more clear):

image

averbraeck commented 10 months ago

In the above example, only Natucity had a discount rule from round 2 onward (and the protection weakened from round 3 onward). As expected, discounting takes place in round 3 with the first 10 k.

averbraeck commented 10 months ago

When we change the river flood level to 10, no discount is applied:

image

When we change the flooding to happen in round 1, correct discounting is applied:

image

And when the flooding takes place in both round 1 and round 2:

image

averbraeck commented 10 months ago

Calculations look correct.