Spendable income calculation is weirdly wrong

averbraeck / housinggame-player

Player app for the housing game

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Spendable income calculation is weirdly wrong #54

Closed vjcortesa closed 2 months ago

vjcortesa commented 7 months ago

[ ] The spendable income is calculated wrong from round 1 for two of the three players of this testing session that I was running to recreate the bug of the IHE-Delft session: t2p5 (IHE-Delft): t1p1 (Test) -> U10 (R1: Sand bags) t2p4 (IHE-Delft): t1p2 (Test) -> N07, I cound not retrieve from the facilitator side where was that player living at the IHE-Delft round 1 t2p6 (IHE-Delft): t1p6 (Test) -> U04 (R1: Green garden and rise level)
[ ] The error was not present when testing the player alone
[ ] The error appears when trying to buy improvements
[ ] At last, the website broke when I advanced the game steps with some of the players not all on the table, upon approval from the facilitator. When I tried to continue with this player, instead of a warning the website broke up

averbraeck commented 7 months ago

@vjcortesa : Question: did you run the different players at the same time on the same computer in different tabs / screens of the browser? If so, the results of the players can get mixed and overwritten. Only one player should play at a given time on a computer.

If not, I will have to try to reproduce the error.

vjcortesa commented 7 months ago

@averbraeck , I got this error by playing two players in different browsers (one in chrome, one in explorer) and one player on my phone (Test t1p2) was on my phone and was wrong

averbraeck commented 7 months ago

Strange. I have not been able to reproduce any error like this. The bottom left player looks as if there was a timeout. When I log in as t1p1 in that session now, I get normal screens:

The wrong calculation at the bottom right is because it is incomplete -- the taxes, mortgage, and bought measures are missing. I will repair that.

The two screens in the top row have a difference of 20k. That is indeed strange, and looks as if the taxes have been deducted twice. I looked in the database, and also there the calculation wold end up being 20 k more positive. Did you do something special with the players in the test session, e.g., advancing the facilitator far ahead of the player, like closing the buying and then buying afterward? Or did everything go normal?

averbraeck commented 2 months ago

The income looks correct in the last sessions that were played, and the calculation that is shown on the screen in the Budget tab is complete.