averbraeck / medlabs

Agent-Based Simulation for Disease Spread in Cities and Regions
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

medlabs : update the dsol to 4.2.1 and parent is moved #2

Closed webos21 closed 3 months ago

webos21 commented 4 months ago

project structure is changed : medlabs-parent dsol version update to 4.2.1

averbraeck commented 3 months ago

Issue #5 has taken care of this update, keeping the original structure of the project (this is needed, because other private projects at TU Delft are dependent on this project as well). There were some issues with the update of the EventProducer in the pull request -- the correct update is to change the EventProducer from the previous djutils/dsol version to the LocalEventProducer (where an alternative could be an RmiEventProducer in case of a distributed application) in the latest version.

To keep consistency between contributors to the project who use Eclipse, indeed a .settings folder is present on github. This folder can be ignored when forking the project and using another development platform. This is the reason for not removing these folders.

Finally, all projects by the team use the Allman style of placing the curly braces, rather than the K&R style which is more popular nowadays (see https://en.wikipedia.org/wiki/Indentation_style). This might change in the future, but not right now.

Therefore, the pull request is not included in the project, but issue #5 implements all changes in updates of the libraries on which the medlabs project is dependent.