search

averi-studios / world-scribe-2-desktop

Desktop app for World Scribe 2
https://worldscribe2.averistudios.com/
GNU General Public License v3.0
24 stars 4 forks source link

The code has no automated tests #16

Open digulla opened 3 years ago

digulla commented 3 years ago

Describe the bug The developer team has not decided on a framework to run automated tests in. This makes contributing hard and soon, it will be too late and too messy to introduce tests. This will lead to a lot of pain and suffering which is why I'm not posting this as a feature request but a bug.

Steps to Reproduce npm test fails.

Additional context (OPTIONAL) I've had very good experience with Jest (https://jestjs.io/). It supports React and and snapshots, so that should work well for this code.

Note: Maybe the server project would benefit more from fixing this.

MarquisLP commented 3 years ago

This makes contributing hard and soon, it will be too late and too messy to introduce tests. This will lead to a lot of pain and suffering which is why I'm not posting this as a feature request but a bug.

This is a great point; I myself have run into this issue during development of the original World Scribe app on Android. To prevent this test-less-ness from becoming too entrenched in World Scribe 2, we'll consider prioritizing tests higher on the roadmap.