search

averixus / floristics

Minecraft spigot server plugin to regrow plants naturally over time.
8 stars 7 forks source link

Mushrooms grow on grass in sunlight #16

Closed Cassolotl closed 4 years ago

Cassolotl commented 4 years ago

Screenshot 2019-11-30 at 13 23 48

averixus commented 4 years ago

Changed my mind! I'm considering this intended behaviour because it replicates the way mushrooms generate in vanilla. Sometimes they show up in 'invalid' locations (where they couldn't be placed manually), so I think it's reasonable to except the same with regrowth.

If anyone strongly feels the opposite, please comment again and I may reconsider!

Cassolotl commented 4 years ago

I think it is a bit different to plants appearing in invalid locations, because when that happens usually if you update a nearby block the plant realises it's invalid and drops. But also I don't mind that much. :)

averixus commented 4 years ago

You're right, I was wrong! Vanilla mushrooms do check light levels so this needs fixing to replicate that. :)

averixus commented 4 years ago

Now I'm unsure again :D In vanilla some mushrooms generate in all biomes restricted by light level (for caves), and some mushrooms generate in certain biomes only (swamp, mushroom fields, mega taiga) on the surface with no light level checks. So I'm back to thinking this is probably intended behaviour. But I'm open to being convinced, so I'll leave this undecided for a while.

averixus commented 4 years ago

I'm declaring this closed again, as of 2.4! I've added mushroom growth in low light levels in all biomes (as per vanilla). Surface mushrooms in bright light are valid vanilla behaviour in certain biomes (like mushroom fields), so I'm considering it acceptable even if they generate on blocks that are unusual for the biome (like grass).