averne / Fizeau

Color management on the Nintendo Switch
GNU General Public License v2.0
339 stars 15 forks source link

"Correction active" toggle results in freeze and crash on latest version #51

Closed pixeltester closed 1 year ago

pixeltester commented 2 years ago

I'm experiencing the following freeze and crash with the latest commit of Fizeau:

Console and environment: Switch Lite (Mariko), atmosphere 1.3.2, firmware 14.1.1 Sysmodules: Tesla + Fizeau

The console freezes then reboots when selecting the "Correction active" toggle in either the overlay or the homebrew. I also use Tesla on an Erista console and this does not happen there, so it seems to be a hardware specific issue? Also to note that Fizeau works normally otherwise, just that the toggle triggers the crash.

These crash and fatal reports are generated: https://gist.github.com/pixeltester/03f9ec8dfdce71756b5075b510e3d9b4

ponymuch commented 2 years ago

Same Question, Switch Lite Version.

pixeltester commented 2 years ago

Same Question, Switch Lite Version.

I'm not sure if averne is active at the moment. I'm still using the chainloader version which works, you just have to remember not to touch the "Correction active" toggle.

pixeltester commented 2 years ago

I was able to check this on another Mariko console, seems to be exclusively a Switch Lite issue.

averne commented 1 year ago

Hi, can someone give these a try and confirm whether this problem is fixed? Fizeau-2.3.1-25dbcb7.zip Fizeau-chl-2.3.1-25dbcb7.zip

pixeltester commented 1 year ago

@averne Just tested it and I can confirm that it's fixed, thanks!

I'm curious. Could you explain why this only happened on the Lite model?

averne commented 1 year ago

Could you explain why this only happened on the Lite model?

https://github.com/averne/Fizeau/blob/master/sysmodule/src/nvdisp.cpp#L82 I try to set something on the external screen, however lite units don't have the corresponding hardware and nvidia's driver crashes instead of returning an error