search

avernois / devfriendlyplaces

Note: devfriendlyplaces has moved to an organisation. Code and data can be found at https://github.com/devfriendlyplaces
61 stars 60 forks source link

change address of Coolworking #126

Closed nostradamnit closed 9 years ago

nostradamnit commented 9 years ago

simple address change

avernois commented 9 years ago

Thanks

nostradamnit commented 9 years ago

Hey Antoine,

I've got another one but I didn't know how to do a pull request by commit... I've added Marmande to the map. I'll create another pull request.

Thanks, Sam

On Mon, Mar 2, 2015 at 10:03 AM, Antoine notifications@github.com wrote:

Thanks

— Reply to this email directly or view it on GitHub https://github.com/avernois/devfriendlyplaces/pull/126#issuecomment-76677880 .

nostradamnit commented 9 years ago

nevermind, you got it already :)

Thx, Sam

On Mon, Mar 2, 2015 at 10:05 AM, Sam Cranford sam.cranford@gmail.com wrote:

Hey Antoine,

I've got another one but I didn't know how to do a pull request by commit... I've added Marmande to the map. I'll create another pull request.

Thanks, Sam

On Mon, Mar 2, 2015 at 10:03 AM, Antoine notifications@github.com wrote:

Thanks

— Reply to this email directly or view it on GitHub https://github.com/avernois/devfriendlyplaces/pull/126#issuecomment-76677880 .

avernois commented 9 years ago

Afaik, you can make a pull request "per commit". Pull request are per branch. So if you want to make different pull request you have to make your changes in different branches.

But, in that case, all commits in the same PR is fine for me.

I only require different PR if you want to add/update places and add/change features

Hope this helps

Thanks