search

avernois / devfriendlyplaces

Note: devfriendlyplaces has moved to an organisation. Code and data can be found at https://github.com/devfriendlyplaces
61 stars 60 forks source link

Refactor tests #192

Closed francois2metz closed 7 years ago

francois2metz commented 7 years ago

To make my PR #191 more readable, here is the part where we refactored the test suite to not use phantomejs, and remove vendorized version of the deps.

Running tests is as easy as yarn test. Note that you also use npm test.

avernois commented 7 years ago

That's a great work, but I have mixed feelings about it.

We used phantomjs and fixed vendor version on purpose: we could run the tests without anything other than a web browser.

@pointbar an opinion on the subject?