averrin / color-tabs-regex

Use color-tabs package with regex.
https://atom.io/packages/color-tabs-regex
MIT License
8 stars 6 forks source link

Use something more user-frendly than regex #4

Closed bojidar-bg closed 9 years ago

bojidar-bg commented 9 years ago

It is much simpler to write rules using minimatch rather than regex. (Note that you can convert minimatch to regex if you think it is better...).

The best option will be to support both regex-based matching and minimatch/glob matching, but I can't wrap my head around it right now... :smile:

I might try to make a PR out of it... one day...

averrin commented 9 years ago

Nice idea, i already see, that regex isnt friendly. I will smoke some documentation about atom packages and minimatch. PRs are welcome=)

bojidar-bg commented 9 years ago

BTW, should I submit more matching-related ideas? :smiley:

averrin commented 9 years ago

@bojidar-bg yeah. For now i prefer simple String.match, but i will implement all interesting ideas.