averyh22 / id-sp17-wiki

Wiki page of the constellation Leo.
https://averyh22.github.io/id-sp17-wiki/index.html
0 stars 0 forks source link

Scoring Rubric #1

Open jgagne opened 7 years ago

jgagne commented 7 years ago

Single-Serving Wiki To-Dos

20 to-dos, 5 points each; plus 4 extra credit to-dos

Essential

Code

30 points

Design

45 points

Optimization

5 points

Test

10 points

Git

10 points

Extra Extra

20 points

jgagne commented 7 years ago

Resolve HTML issues: https://validator.w3.org/nu/?doc=https%3A%2F%2Faveryh22.github.io%2Fid-sp17-wiki%2Findex.html

Minor Issues

Before

<h2>Features</h2>
<summary> <b>Contents</b></summary>
<nav>
<ul>
<li><a href="#stars">Stars</a></li>
<li><a href="#deepspaceobjects">Deep-Space Objects</a></li>
<li><a href="#meteorshower">Meteor Shower</a></li>
<li><a href="#history">History and Mythology</a></li>
<li><a href="#visualizations">Visualizations</a></li>
</ul>
</nav>

Note: The <summary element can only be used within the <details> element. Remove. Now, next your <h2> inside the <nav> as that section's heading.

Atter

<nav>
<h2>Features</h2>
<ul>
<li><a href="#stars">Stars</a></li>
<li><a href="#deepspaceobjects">Deep-Space Objects</a></li>
<li><a href="#meteorshower">Meteor Shower</a></li>
<li><a href="#history">History and Mythology</a></li>
<li><a href="#visualizations">Visualizations</a></li>
</ul>
</nav>

Minor Issues

Before

<section id="#top">

After

Remove <section id="#top">. Instead add id to instead, but remove# before top.

<body id="top">

Before

<main class="max-width">
  <hr>
  <h1>About…</h1>

Note: Remove <hr> and , but most importantly remove the <hr> (it's unnecessary). If you want a horizontal rule use a CSS border (border-top: …;).

After

<main class="max-width">
  <h1>About</h1>
jgagne commented 7 years ago

Style navigation and "Back to Top!" links.

jgagne commented 7 years ago

Resolve CSS issues: http://jigsaw.w3.org/css-validator/validator?uri=https%3A%2F%2Faveryh22.github.io%2Fid-sp17-wiki%2Findex.html&profile=css3&usermedium=all&warning=1&vextwarning=&lang=en

Remove <style> tag. Remove comments made with ! or properly comment out with /* this is markup for a proper comment in CSS */.

jgagne commented 7 years ago

Clean-up repo, remove raw and backgrounds-images folders. Please, add comps folder and include a comp for this website. Thanks!

jgagne commented 7 years ago

Include <link rel="canonical" href="…"> (add url) to cite original source of content.