averyvery / freeway

Simple Routing for EE
43 stars 4 forks source link

Freeway matching partial routes incorrectly. #10

Open bryantAXS opened 11 years ago

bryantAXS commented 11 years ago

Hey Doug,

You helped me with this problem a while ago on Devot-ee and your fix worked perfectly. Just a reminder to add it to this codebase because it's currently incorrect, and a pretty big issue I've ran into a few times.

http://devot-ee.com/add-ons/support/freeway/viewthread/5537

Thanks!

averyvery commented 11 years ago

Hi bryant,

Thanks for the reminder. I started rewriting Freeway this spring to address this problem, create tests, and add a whole bunch of new features — however, I stopped work due to lack of personal interest, and the existence of an alternative ( http://devot-ee.com/add-ons/router ). I guess I was rolling this change in with the new version, and forgot to push it into the old one. The change should be up now!

-Doug

bryantAXS commented 11 years ago

Awesome, thanks Doug!

On Sun, Oct 14, 2012 at 7:25 PM, Doug Avery notifications@github.comwrote:

Hi bryant,

Thanks for the reminder. I started rewriting Freeway this spring to address this problem, create tests, and add a whole bunch of new features — however, I stopped work due to lack of personal interest, and the existence of an alternative ( http://devot-ee.com/add-ons/router ). I guess I was rolling this change in with the new version, and forgot to push it into the old one. The change should be up now!

-Doug

— Reply to this email directly or view it on GitHubhttps://github.com/averyvery/freeway/issues/10#issuecomment-9429803.

Bryant Hughes bryant@thegoodlab.com www.thegoodlab.com @thegoodlab http://www.twitter.com/thegoodlab