Open daviddias opened 5 years ago
Hi @avh4, did you had the chance to look at this PR? Alternatively, can you let me know what should be my expectation in a review/consideration/merge/release? Thank you! :)
Hi @avh4! I'm pretty sure you are really busy. Let me know when you have a chance to read this PR and if you intent do review it or if you have different plans when it comes to keep supporting this module.
Hi, sorry for the long delay on a reply!
After reading #38, I think it would be preferable to make binaries
allow folder names as you tried in your original attempt rather than leaving that still not working and adding a new configuration option. Besides being a simpler config API, allowing folder paths in binaries
would also be more flexible to allow multiple binaries to be in different nested folders.
Lmk if you want to try to do a fix that way (and if not, you should be able to make use of your fork in the meantime either by publishing it with a scope as @<username>/binwrap
or by using git urls in your package.json)
After reading #38, I think it would be preferable to make binaries allow folder names
I might be misunderstanding you, but from what you describe, that is exactly what this PR achieves. Look at https://github.com/ipfs/npm-go-ipfs/pull/24/files for an example of that.
Hi @avh4, this PR fixes https://github.com/avh4/binwrap/issues/38 so that binwrap can find binaries in nested directories.
Let me know if this PR is ok. I followed the codestyle but since there was no contributing.md, I might have missed something.
Note: I was able to successful get it to work with my own binary but I was never successful running the tests in the repo either with master or my fork. The error was:
Update: Apparently it might be something with my setup. Travis runs the tests like a charm https://travis-ci.org/avh4/binwrap/builds/584012655