search

avh4 / binwrap

Distribute binaries via npm
39 stars 17 forks source link

Migrate from request to node-fetch #54

Open tamaracha opened 3 years ago

tamaracha commented 3 years ago

Hi, this package looks interesting for my purposes, but the request deprecation warning is nasty. Could it be a possible approach to take smaller steps and migrate to a lighter HTTP client? I have migrated from request to node-fetch in my fork. This gets rid of about 40 dependencies, the tests run 2 seconds faster, and node-fetch supports redirects.

sporto commented 1 year ago

@avh4 any chance you merge this soon?

https://github.com/avh4/binwrap/issues/65 is a big issue for a couple of important Elm related npm packages that use this package (elm-format and elm-json).

Otherwise, here is a list of other possible alternatives https://github.com/request/request/issues/3143 I could make a PR if you prefer to use some of the others.

Thanks