Implement basic conversions

avh4 / elm-color

Standard representation of colors, encouraging sharing between packages. (This replaces elm-lang/core#Color from Elm 0.18.)

BSD 3-Clause "New" or "Revised" License

23 stars 6 forks source link

Implement basic conversions #5

Closed avh4 closed 6 years ago

avh4 commented 6 years ago

Collaborating on this PR:

Check the most-recent comments on this PR to see if anyone is actively working on it. If not, continue:
Post a commenting stating what you are starting work on
Make a PR against this branch (basic-conversions)
Post a comment when you are done doing active work so others can pick up from there (including a link to your PR against this branch)

To include the following from the detailed discussion at #4:

[x] fromRgba : { red : Float, green : Float, blue : Float, alpha : Float } -> Color
[x] rgb255 : Int -> Int -> Int -> Color
[x] rgb : Float -> Float -> Float -> Color
[x] rgba : Float -> Float -> Float -> Float -> Color
[x] toRgba : Color -> { red : Float, green : Float, blue : Float, alpha : Float }
[x] toHex : Color -> { hex : String, alpha : Float }
[x] fromHex : String -> Color

avh4 commented 6 years ago

I'm stopping work for tonight. Feel free to contribute following the instructions at the top of this PR. I'll comment again when I'm picking this up again.

2mol commented 6 years ago

I will now start work on the functions above that you haven't done yet, as well as some of the documentation.

2mol commented 6 years ago

Ok, done for the day. I hope I'm not forgetting anything, but I should have done the following:

completed all fromRgb functions
clamp color channels to 0.0 - 1.0
doc fixes and tweaks
consolidated fromRgb functions, to make sure we're only using one implemented logic
toHex done
fromHsla and related functions done

https://github.com/avh4/elm-color/pull/7

I hope nothing is too bikesheddy! If anything seems that way, it's just that I'm in the habit of changing things immediately, as I come across them.

Cheers

avh4 commented 6 years ago

I'm picking this up again, starting with merging 2mol's PR and adding tests for the conversions added there, and then finishing fromHex.

avh4 commented 6 years ago

I'm moving the HSL work to a separate branch (#8), since it seems like it will be a bit of work to get the conversion accurate.

avh4 commented 6 years ago

I'm done working on this for tonight. Remaining work is to finish fromHex, (and the HSL conversions were moved to #8 )

avh4 commented 6 years ago

I'm picking this up again to finish fromHex

avh4 commented 6 years ago

Merging to dev-1.0.0 branch -- further comments can go to #9