Open ianmackenzie opened 4 years ago
Yeah, I'd be happy to accept a PR for this 👍
Cool! I do remember running into some "huh..." moments when I wrote my custom implementation of Control.float
for my own use case - I vaguely seem to remember concluding that it was inherently different from some of the other controls, in ways that made it non-obvious how to match existing patterns.
I'll try to take another look at the code again and see if I can refresh my mind on what these issues were - are there any particular principles you've been trying to follow with the existing controls, or gotchas to be aware of to make sure that layout works out in a reasonable way in all cases?
I haven't worked on this in quite a while, but just to dump out the context I recall:
in a future major version, both those things are up for reconsideration, but in the meantime, I've just been living with the current mess, and trying to keep notes of the cases that don't work right to inform the later potential redesign.
It would be great to have something like
implemented as a slider (in my case, I'd like to make some debug UIs for experimenting with different
elm-3d-scene
parameter values).Control.int
could be implemented similarly (with a step size of 1 set on the underlying HTML slider). Happy to submit a PR if that would be helpful!