search

avh4 / elm-debug-controls

Easily build interactive UIs for complex data structures
https://avh4.github.io/elm-debug-controls/
BSD 3-Clause "New" or "Revised" License
24 stars 4 forks source link

Add stringTextarea Control #4

Closed tesk9 closed 5 years ago

tesk9 commented 5 years ago

Adds a text area control, to support multi-line text. I called it longString -- maybe multilineString would be better?

Screen Shot 2019-09-10 at 12 22 16 PM
avh4 commented 5 years ago

I was thinking textarea might make sense, since that's a term most Elm devs would understand to mean the same thing (whereas input or field doesn't really make sense for the simpler string input since they're pretty vague terms). But yeah, multilineString seems to fit best with the existing string function, though maybe it wouldn't be as obvious what to search for if you didn't know the name already?

longString also seems fine. Let me know if you want to change to one of the other options, or if you want me to merge this as-is.

tesk9 commented 5 years ago

Hmm, I don't feel strongly! All the options seem good. Do you have a preference at all? I'm very happy to change it to textarea or multilineString

avh4 commented 5 years ago

Ah, reading through the API again, I remember the naming scheme I was aiming for: have the data type be the primary focus, and alternate UI widgets be secondary.

Based on that, let's go with stringTextarea if that sounds okay.

tesk9 commented 5 years ago

Love it! change made