Open rlefevre opened 5 years ago
Regarding andThen lambdas alignment #568
- Arithmetic expressions examples
This looks like an issue, which I assume only affects code blocks in doc comments.
- Markdown link bug
Is this actually a bug? Does elm-markdown not support shortcut reference links https://spec.commonmark.org/0.29/#shortcut-reference-link (babelmark) ?
What I think is a bug is that [Module](Module)
is parsed as a link, then rendered as an autolink <Module>
which is not valid as it it's not an absolute URI. It is therefore ignored by elm-markdown
.
I have submitted a fix proposal in https://github.com/avh4/elm-format/pull/649.
However I don't know that well "shortcut reference link`, so I may have overlooked something.
Oh I see π I was looking at
-**Historical Note:** The name `Int` comes from the term [integer][]. It appears
+**Historical Note:** The name `Int` comes from the term [integer]. It appears
instead of [Module](Module)
I'm sorry you were right. The markdown bug exists but does not occur in elm/core
. I don't know why I was thinking about it when noticing the [integer][]
change. Sorry for the confusion.
This looks like an issue, which I assume only affects code blocks in doc comments.
Yes, it seems linked to the unary minus being interpreted as a minus operator in a multi-line expression. I have opened https://github.com/avh4/elm-format/issues/652.
I think the Unicode characters case was fixed in 0.8.4.
In the spirit of targeting 1.0 being used in core libraries, I did a diff with
elm/core
using Allow single-lineif
expressions and Allow single-line case-expressions branches to see if there are major differences that could require some remaining discussion.As
elm/core
seems to mix indentations of 2 spaces vs 4 spaces, uses[1, 2, 3]
syntax for lists/tuples instead of[ 1, 2, 3 ]
, and does not always put the same blank lines, here is thegit diff
result usinggit diff --ignore-all-space --ignore-blank-lines | grep -v '^\+$'
:So it looks pretty good. Here are a few remaining differences worth mentioning:
1. Unicode characters
in documentation is replaced by:
This breaks the point of the example.
2. Arithmetic expressions examples
The following arithmetic examples:
become broken:
3. ~Markdown link bug~
~This is due to https://github.com/avh4/elm-format/issues/339.~
Edit: I was thinking about another bug about markdown links. This one is not a bug and should therefore not be an issue for
elm/core
withelm-format
.4.
andThen
lambdas alignmentBecomes
~I know that this has been already discussed, but is there an
elm-format
issue for this?~ Edit: Discussed in https://github.com/avh4/elm-format/issues/568 Should this be part of0.9.0-exp last experimental features before 1.0
milestone?