Allow building on Linux ARM64

avh4 / elm-format

elm-format formats Elm source code according to a standard set of rules based on the official Elm Style Guide

BSD 3-Clause "New" or "Revised" License

1.31k stars 145 forks source link

Allow building on Linux ARM64 #777

Closed tfausak closed 1 year ago

tfausak commented 2 years ago

This would address #714 and #765. It's similar to #769.

These changes allow elm-format to be built on an ARM64 (AArch64) Linux machine. I have tested them with AMD64 (x86-64) as well, which continues to work as expected.

ismaelga commented 1 year ago

Bumped into the same issue. This PR seems legit. Thanks! Hope it gets merged

avh4 commented 1 year ago

Huh, github seems confused about the list of commits after I fixed the merge conflicts here. :shrug:

Merging.

avh4 commented 1 year ago

Thanks! This is on main branch now. I haven't set up linux aarch64 CI yet, so lmk if there's still any problems.

jsynacek commented 1 year ago

Awesome, thanks a lot! Would you mind releasing a new version so that the builds show in the release and also in the npm archives?

avh4 commented 1 year ago

The release is tracked here: https://github.com/avh4/elm-format/milestone/31

Basically I have to do a test run of the new npm publishing process, then get linux-aarch64 binaries to build on CI, then take a look at building musl binaries, and then do the release. 🤞