search

avh4 / elm-program-test

Test Elm programs
https://elm-program-test.netlify.com/
MIT License
93 stars 27 forks source link

Fix click link for applications #166

Closed nunntom closed 2 years ago

nunntom commented 2 years ago

Hello

I recently ran into Issue #107 while using this excellent package. I also found a related issue where using pushUrl with a query and/or fragment and then parsing the resulting URL would fail to give the correct results. This PR attempts to address both of these.

The tests added in ClickLinkTest and NavigationTest would fail in the current version.

The implementation of Url.Extra.resolve could probably be done in a nicer way but for now it seems to serve the purpose and hopefully is an improvement at least.

All feedback and modifications gratefully received.

Closes #107

avh4 commented 2 years ago

Awesome! Thank you!

FYI I'm gonna try to take care of a few other issues https://github.com/avh4/elm-program-test/milestone/16 over the weekend before making the 3.6.4 release. (If you want to pick any of those up, feel free to :D)

nunntom commented 2 years ago

Awesome! Thank you!

FYI I'm gonna try to take care of a few other issues https://github.com/avh4/elm-program-test/milestone/16 over the weekend before making the 3.6.4 release. (If you want to pick any of those up, feel free to :D)

That was fun! I'll keep an eye out for anything else I can contribute to. Thanks!