Parse query find always expects 1 element error

avh4 / elm-program-test

Test Elm programs

https://elm-program-test.netlify.com/

MIT License

93 stars 27 forks source link

Parse query find always expects 1 element error #171

Closed nunntom closed 2 years ago

nunntom commented 2 years ago

Hi @avh4. In the interests of helping get your next release out, I thought I'd attempt to tackle issue #154 which is on the milestone. Not totally sure about the naming of MultipleElementsFailure. Let me know what you think.

[x] Add a failing test in tests/ProgramTestTests/UserInput/ClickButtonTest.elm
[x] grab the current error message from that and use it to add a test in tests/ProgramTest/TestHtmlHacksTest.elm
[x] implement parsing of the error message in src/ProgramTest/TestHtmlParser.elm
[x] make sure tests pass now
[x] update CHANGELOG.md
[x] PR should be made against or switched to the "develop" branch (not "main")

Closes #154

avh4 commented 2 years ago

@nunntom sorry about the release delay; I thought I was gonna have a bit more time for this. I'm just gonna do a release now of the stuff that's been merged already so I don't delay things further.

This PR looks good, though I want to review the code there and make sure there aren't some of the pleaseReport branches that we actually should try to handle in a better way, so I'm gonna do the release of the currently merged stuff first, and come back to this later.

nunntom commented 2 years ago

@nunntom sorry about the release delay; I thought I was gonna have a bit more time for this. I'm just gonna do a release now of the stuff that's been merged already so I don't delay things further.

No problem. Thanks for releasing the other stuff!

This PR looks good, though I want to review the code there and make sure there aren't some of the pleaseReport branches that we actually should try to handle in a better way, so I'm gonna do the release of the currently merged stuff first, and come back to this later.

Sounds like a good idea. :)