Removing dependency of syncprompt #66

jah2488 commented 6 years ago

A relatively simple PR that removes syncprompt in favor of using node's built in readline library.

There were a handful of other places I can see where improvements could be made, but decided to attempt and keep this PR more focused.
The majority of the diff is actually caused by PrettierJS, happy to clean that out of the PR and make be only my changes if needed.

I had issues running the tests with yarn test, but if I ran the code found in yarn test manually, everything passed fine.

avh4 commented 6 years ago

Cool, yeah looks like the CI failure is because of prettier.. I usually just fix it with npx prettier --write upgrade.js

jah2488 commented 6 years ago

@avh4 🤦‍♀️ Yah, my editor's prettier config was overwriting the one for the project and causing the tests to fail. Pushed up a fix.

avh4 commented 6 years ago

Looks good! Forgot to remove syncprompt from package.json, though

jah2488 commented 6 years ago

@avh4 Its been a long day 😅

avh4 commented 6 years ago

Awesome, thanks!!

avh4 / elm-upgrade