I would prefer to keep the "numeric" code as a string since the convention is 3 digits, padded with leading zeroes (and padding int literals with zeros is superfluous as the clippy lints point out), and we can relatively easily convert to an int with .parse::<u16>() if we need to. In saying that, for the integer case, we can use format!("{:0>3}", 12.to_string()), for example.
Let me know your thoughts. Cheers!
Edit: I would suggest touching base in an issue or Discord prior to making a (large) PR, just so it can be discussed first.
Hi thanks for the PR :)
I would prefer to keep the "numeric" code as a string since the convention is 3 digits, padded with leading zeroes (and padding int literals with zeros is superfluous as the clippy lints point out), and we can relatively easily convert to an int with
.parse::<u16>()
if we need to. In saying that, for the integer case, we can useformat!("{:0>3}", 12.to_string())
, for example.Let me know your thoughts. Cheers!
Edit: I would suggest touching base in an issue or Discord prior to making a (large) PR, just so it can be discussed first.