`autodiff`: improve the Graphviz visualisations.

avhz / RustQuant

Rust library for quantitative finance.

https://docs.rs/RustQuant

Apache License 2.0

982 stars 108 forks source link

`autodiff`: improve the Graphviz visualisations. #74

Open avhz opened 1 year ago

avhz commented 1 year ago

There are problems with the Graphviz plotting of the computation graphs in autodiff:

[ ] The nodes don't indicate the operation that took place (e.g. +, sin).
[ ] There are double links from one node to others (e.g. input x1 has two edges to Op_3).
- The edge should not be drawn if the weight is 0.

graphviz

nicola-corbellini commented 10 months ago

Hello! Along my path to start learning Rust I've come across your repository and I'd like to tackle this issue if it's not out of the scope of my current skills.

May I ask for a hint? Where could I get the operation performed on the input? I haven't found it available either in the Variable nor in the Graph. Thank you

avhz commented 10 months ago

Hi thanks for the interest! Unfortunately there's no current way to retrieve the operation performed, and this would need to be added.

JainVidit12 commented 10 months ago

Created Pull request #131 to address this.

0xJepsen commented 7 months ago

Might i recommend the plotters library as well? We have used it quite a bit and found it to be really good.