search

avi12 / skillshare-player-control

Basic keyboard controls for Skillshare's player.
GNU General Public License v3.0
11 stars 2 forks source link

[Bug] Play/pause button doesn't work #8

Closed niccololamolo closed 1 year ago

niccololamolo commented 1 year ago

Describe the bug

Pause/play button doesn't work.

How to reproduce

use video player

Expected behavior

play/pause button is the most important button, it should work

What browser(s) can you reproduce the issue on?

Chrome

What OS does it occur on?

macOS

What's the version you're running?

2.0.1

Additional context

No response

avi12 commented 1 year ago

It should work once you focus on the video player

niccololamolo commented 1 year ago

It does not work at all and "play/pause" button doesn't appear on hotkeys map either

Screenshot 2023-05-31 at 11 47 37 AM
avi12 commented 1 year ago

I must've forgotten to list that shortcut, my bad

avi12 commented 1 year ago

Later today I'll give a deeper look into it as well as list the shortcut

niccololamolo commented 1 year ago

Thanks. I find it very odd that the Skillshare video player lacks such basic functionality. Especially given that they have so many courses that purport to train people to build such functionality.

I wonder how many customers Skillshare has missed out on because their player sucks?

Pretty cool that people like you are there to fill the gaps though

avi12 commented 1 year ago

Indeed, I made this extension after I discovered that no one else made one 😁 If you can, I'd love it if you could donate to me :)

avi12 commented 1 year ago

Let me know if this version works for you: skillshare-player-control-2.0.4.zip How to install

niccololamolo commented 1 year ago

Works now, well done

avi12 commented 1 year ago

Still got one bug to fix, which is focusing on the video player when pressing Shift+N/P Skillshare is giving me a great headache with it lol Sadly my day is over, but hopefully, I'll continue tomorrow and push the update ASAP