[Bug] not working on embeded videos for me

[dnmTX]

Describe the bug

I'm not sure after which update it started but as of late i've noticed that on embeded videos when start playing it remains on the lowest resolution possible.

How to reproduce

Here is a sample link: https://9to5google.com/2022/03/18/chrome-site-search-activate/

These are my settings:

And this is how it looks on my end:

To make sure,i checked if 720p exist and it does:

The extension works fine on youtube.com. Looks like only the embeded videos are affected on my end.

Expected behavior

To convert to the user's resolution of choice. Simple as that.

What browser(s) can you reproduce the issue on?

Slimjet Version 39.0.2.0 (based on Chromium 111.0.5563.41) (Official Build) (64-bit)

What OS does it occur on?

Windows 10 1607

What's the version you're running?

1.7.14

Make sure the bug wasn't reported before

• [X] I'm the first one to report it

Additional context

NONE

[avi12]

I'm pretty sure that the bug is in https://github.com/avi12/youtube-auto-hd/blob/5d035ac79b0c5251c802b206c77955252a323b29/src/contents/content-script-init-desktop.ts#L113-L117

i.e. I force check for whether a logo has loaded there even though it will never load in an embedded video

[dnmTX]

Thanks @avi12. If you make a test(unpacked) build i can test it on my end.

[avi12]

chrome-mv3-prod.zip

[dnmTX]

Ok,stand by for results.Also if you know any other websites with embeded YT videos would be helpfull 👍

[avi12]

I'm pretty sure I also have to deal with https://github.com/avi12/youtube-auto-hd/blob/acb6f497b7bfe002225dd51d9d5d494a760d2db9/src/cs-helpers/desktop/content-script-desktop.ts#L56

[dnmTX]

No change,unfortunatelly 😞

[avi12]

chrome-mv3-prod.zip

[dnmTX]

Alright...back in business 👍 Again,to make sure it's working,if you know couple more websites with embeded videos,post them here please.

[avi12]

The only additional thing I need to check is for #99

[dnmTX]

Ok,i got it,found another site and can confirm it's working as it should. Will wait for the official release so i can update the original extension. Thanks again @avi12 for that fast resolution. Closing as RESOLVED 👍

P.S. Here is a another test link(if you need it): https://www.engr.colostate.edu/~dga/youtube-embed-test-page/

[avi12]

Since I had already pushed #105, it will take a little longer for #106 to go through

[dnmTX]

Since I had already pushed https://github.com/avi12/youtube-auto-hd/pull/105, it will take a little longer for https://github.com/avi12/youtube-auto-hd/pull/106 to go through

I have a working extension so i can wait.No problems here and thanks again 👍

[avi12]

Update 1.7.16 is nove live

[dnmTX]

Thanks for the heads up @avi12 👍 Already updated,works like charm 🚀