[Bug] Does not change resolution properly on playlist (auto-next)

fizzfaldt commented 1 month ago

Describe the bug

When switching videos on a playlist, resolution change is lost.

For example:

If I open https://www.youtube.com/watch?v=DWRZs0oNzpw&list=ELH4bU6wduq321WDJVI05olQ&index=15&pp=sAQB then the video will properly play at 1080P (like my settings like)
If I let the video finish (or press Shift-N/Shift-P to go to next/previous video in the playlist), when the new video starts, it'll play in 480P instead. I WILL see the 1080p/HD icon flash very quickly before it goes away.

How to reproduce

Open playlist:

https://www.youtube.com/watch?v=DWRZs0oNzpw&list=ELH4bU6wduq321WDJVI05olQ&index=15&pp=sAQB
Notice it's properly going to HD
Seek to end of video and let it auto-move on to next video (or just use NEXT key to skip immediately)
Notice new video plays at 480P

Expected behavior

The quality should still honor my preferences even on next videos in a playlist.

What browser(s) can you reproduce the issue on?

Chrome, Firefox

What OS does it occur on?

Linux

What's the extension version you're running?

1.8.25

Make sure the bug wasn't reported before

[X] I'm the first one to report it

Make sure that YouTube Auto HD + FPS is the only extension running on YouTube

[X] The issue still persists after disabling any other YouTube extension

Additional context

Looks like there was a similar bug YEARS ago: https://github.com/avi12/youtube-auto-hd/issues/11 (fixed in https://github.com/avi12/youtube-auto-hd/pull/12 ) but it looks like the bug (or similar) bug is back.

If you can't repro it I'm happy to follow debugging instructions to get you more data.

I've reprod it on Chome&Firefox in Linux, and Chrome & Firefox in OSX. Note: on OSX it only reproed 90% of the time (once or twice it properly went to HD, possibly cause AUTO happened to choose HD?)

fizzfaldt commented 1 month ago

When checking repro, I guess make sure to click on quality and make sure it's explicitly following the youtube hd setting rather than coincidentally picking it using AUTO. If you can't repro it please send me instructions on what debugging information you want, and which browser/machine you want it on (firefox/chrome, linux or osx)

fizzfaldt commented 1 month ago

(Close was a missclick, sorry)

avi12 commented 1 month ago

Can you record your screen reproducing the issue so it's easy to follow exactly what you're doing?

avi12 commented 1 month ago

Lmao, you'll need to get another video example 😁

avi12 commented 1 month ago

This is an unsuccessful attempt to reproduce it

https://github.com/user-attachments/assets/71883193-9055-4d11-8008-b784ade50f15

fizzfaldt commented 1 month ago

Ok, it looks like it's not ALL playlists, it's probably only restricted content (like [YouTube Movies & TV] (free or paid) This is basically (somewhat) DRM laden, and it just happens that they're currently not charging for these videos.

I've reprod WORKING (as in it stays in HD all the time) for normal playlists. However playlists on YouTube Movies & TV (official stuff they normally sell but sometimes have "free" videos) cause this problem.

To confirm: MOST playlists work fine & correctly. It looks like it's YouTube Movies & TV files that don't.

14MB video screen recording is too big to attach, so here is a link to my drive for screen recording.

https://drive.google.com/file/d/13TZEOHGLLlhDo1M3smzo2cNa-StBjtdf/view?usp=sharing

fizzfaldt commented 1 month ago

Probably any playlist in this channel: https://www.youtube.com/channel/UCuVPpxrm2VAgpH3Ktln4HXg would cause the same problem (I was able to verify that) but not sure if ANY of them would be available in your country.

Here is the list of TV shows (at least for US) which tends to have playlists, (though some of the shows are 480P only) https://www.youtube.com/feed/storefront?bp=EgCSAQMI7weiBQIoBg%3D%3D

fizzfaldt commented 1 month ago

(ON THAT CHANNEL) Weird.. the shows that are 480P only work properly (if you set pref to 480 or 360 or whatever it's honored). I was only able to find two shows (out of about 10) that had 1080P, and both of those failed to stay in HD.

Obviously sending you links isn't going to help unless some tv shows/playlists there are available in your country.

avi12 commented 1 month ago

I mean, you can build the extension from its source on your machine (the build process should work cross-platform) and then potentially create a PR with an appropriate fix

avi12 commented 1 month ago

Probably any playlist in this channel: https://www.youtube.com/channel/UCuVPpxrm2VAgpH3Ktln4HXg would cause the same problem (I was able to verify that) but not sure if ANY of them would be available in your country.

Here is the list of TV shows (at least for US) which tends to have playlists, (though some of the shows are 480P only) https://www.youtube.com/feed/storefront?bp=EgCSAQMI7weiBQIoBg%3D%3D

lmao

fizzfaldt commented 1 month ago

lmao

Yup.. not surprised NOTHING is available.

I mean, you can build the extension from its source on your machine (the build process should work cross-platform) and then potentially create a PR with an appropriate fix

I remembered how bad Youtube "Paid" tv/videos are (even when "Free"). I was wondering why the quality was low; it was only upscaled to 1080 (the source is 480P and there's 0 additional detail in 1080P so it is just a waste). I've found a better source for the thing... and Youtube paid stuff is mostly junk. The (actual) Paid stuff is even worse cause it works on almost no browsers.

I'll consider doing this in the future if I find something where there's a point. Feel free to close this if you like, or leave it open in case someone else finds a similar one?

avi12 commented 1 month ago

I'll see what I can do about it

avi12 / youtube-auto-hd