avi12 / youtube-auto-hd

A simple browser extension for changing YouTube videos' quality based on FPS.
https://avi12.com/youtube-auto-hd
GNU General Public License v3.0
235 stars 28 forks source link

[Bug] Settings pops up with auto resize enabled #25

Closed Qwarr closed 2 years ago

Qwarr commented 2 years ago

Describe the bug After video auto resizes, When using left or right arrow keys on the keyboard to scroll through the video or seeking on the timeline with the mouse, then often the settings popup of YouTube appears.

To Reproduce Have auto resize enabled and use the arrow keys or clicking on the timeline.

Expected behavior The popup should stay hidden and only appear, when clicking on the gear icon.

Details:

Additional context 2021-12-20 23_57_53-DevTools - www youtube com_watch_v=oHHz2aAFFA0 list=PLyDO0T4aHrDxiV8R-kG86Hkhf1s 2021-12-21 00_02_27-DevTools - www youtube com_watch_v=c-aFE0BXvzI list=PLyDO0T4aHrDxiV8R-kG86Hkhf1s

avi12 commented 2 years ago

Function n is https://github.com/avi12/youtube-auto-hd/blob/64b57d16bba6bf2da474fdd684b95ee32aa53736/src/shared-scripts/ythd-utilities.ts#L8-L39

DakvasBuilds commented 2 years ago

I, too, have noticed this issue. I'm running Vivaldi version 5.0.2497.32, which itself uses Chrome version 96.0.4664.113.

It seemed like after the resizing the video, hitting left or right once would be fine but then pressing it again would then cause the settings to display. I did have to disable the extension for the moment because I have to use the arrow keys to scrub through videos quite frequently and this was getting in the way of what I needed to do. I'd be very interested to know when this is fixed as I also use the Home key to return to the beginning of the video quite frequently but can't use it without the plugin. Thanks!

avi12 commented 2 years ago

Due to New Year's Eve, I barely had any time this weekend However, I did spend some time working on the extension; it was near the end of the day, so I didn't get the result I wanted, therefore, I didn't push an update yet I will do my best this week to work on the extension, and as soon as I get the desired result, I will push the update

DakvasBuilds commented 2 years ago

Oh, no worries at all. Sorry if I made it seem like I was in a rush to have this fixed. I fully understand that time to work on stuff like this is a bit shorter with the holidays.

avi12 commented 2 years ago

To add an insult to injury, Firefox is giving me a headache with the testing; it appears to have a cached version of the extension, which made it seem like the extension is broken, even though it's fully-functional