avi12 / youtube-auto-hd

A simple browser extension for changing YouTube videos' quality based on FPS.
https://avi12.com/youtube-auto-hd
GNU General Public License v3.0
235 stars 28 forks source link

Videos on google drive switch to the highest quality automatically #3

Closed OmarNamis closed 3 years ago

OmarNamis commented 3 years ago

I tried watching a video hosted on google drive from the browser without downloading it, the video player looks exactly like the YouTube player.

Unlike YouTube, videos on google drive have a limited number of qualities available: 360p, 720p, and 1080p as far as I know.

I have my quality set to 480 in YouTube Auto HD, but for some reason the video quality switches to the highest quality available which is 1080p.

I tried manually setting it to 360p, but it kept switching back to 1080p automatically.

The issue doesn't happen if I set the quality in YouTube Auto HD to 360p.

avi12 commented 3 years ago

Strange, I will check it out Thanks for reporting!

P.S. I'm only responding now because GitHub didn't send me any notifications for a strange reason

avi12 commented 3 years ago

After further investigation, the problem actually makes more sense Basically, I checked on a video that has 1080p, 720p, 360p, i.e. no 480p When I set the quality to 480p, the extension couldn't find the quality, so it picked the highest available one The reason it behaves like this is that on YouTUbe you won't have this issue - you'll always have all the qualities up to the highest one, without gaps

avi12 commented 3 years ago

Fixed in version 1.3.3

OmarNamis commented 3 years ago

Thanks a lot for you time and effort!

I tested the new version, and it's working perfectly now!

Though if I may suggest, maybe you can add an option for the user to select their second favorite quality.

For example, if the user chooses 480p as his favorite quality and it doesn't exist, then he can choose 360p or 720p as his second favorite.

avi12 commented 3 years ago

How would such a UI look like?

OmarNamis commented 3 years ago

I guess adding an extra slider would be sufficient.

And maybe it would be fine to make a single slider apply on all frame rates.

avi12 commented 3 years ago

2021-01-08_11-39-43 How's that different from the current situation?

OmarNamis commented 3 years ago

Currently, there's only one slider. What I'm suggesting is adding another one.

So let's say the user choses 480p for the first slider and 720p for the second slider. The extension will first check if the 480p quality exists and sets it, if it doesn't exist it will look for the 720p quality and sets it.

avi12 commented 3 years ago

2021-01-08_12-02-17 And what about this one?

OmarNamis commented 3 years ago

This is not the same, in the picture you can set different qualities for different frame rate. What I want is a priority of qualities.

Like in the Google drive case in my bug report, since 480p doesn't exist, I want to be able to choose the next quality to be set whether it's 360p or 720p.

avi12 commented 3 years ago

Right, but what I'm asking is that you suggest a UI that will incorporate the best of both worlds in a way that makes sense

OmarNamis commented 3 years ago

How about something like this? image

avi12 commented 3 years ago

Ok, what about the multiple FPS ranges?

OmarNamis commented 3 years ago

The slider should apply on all frame rates, so no need to add a separate slider for each FPS.

That's my opinion, what do you think?

avi12 commented 3 years ago

So you're saying that there should be 2 sliders for controlling the qualities of all FPSs (primary and secondary) but only a single slider for each FPS range?

OmarNamis commented 3 years ago

I guess, would that work?

avi12 commented 3 years ago

I mean, it doesn't make much sense to me to have the "secondary slider" functionality available to half of the extension

OmarNamis commented 3 years ago

You could also make the second slider separate from the "same quality for all frame rates" toggle, so a single slider will work for all frame rates whether you have that toggle on or off.

avi12 commented 3 years ago

That's a bit of a problem The whole idea of the FPS separation is to allow users with less-powerful computers to enjoy YouTube as much as possible, so for example 60 FPS videos will always run at 720p whereas 30 FPS videos will always run at 1080p Having a "secondary quality" is a nice idea, but the question is how to visually display the controls for it in the extension popup so that it makes sense without complicating the usage of the extension

OmarNamis commented 3 years ago

I see, perhaps you're right.

avi12 commented 3 years ago

I'm not denying your suggestion, it'd be nice to have a "secondary slider" functionality The biggest challenge is finding a good solution for the UI to make sense for the end-user I'm open to new ideas

carlosjeurissen commented 3 years ago

My proposal would be to keep all the sliders and toggles as is, and add a new toggle which handles whether a missing quality should downgrade or upgrade to a different quality. Which would be downgrade by default.

-------- Original Message -------- On Jan 9, 2021, 11:42, avi12 wrote:

I'm not denying your suggestion, it'd be nice to have a "secondary slider" functionality The biggest challenge is finding a good solution for the UI to make sense for the end-user I'm open to new ideas

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

OmarNamis commented 3 years ago

That's a good idea!

avi12 commented 3 years ago

@OmarNamis Please open a new issue about it so it's visible in the issues list