avi12 / youtube-auto-hd

A simple browser extension for changing YouTube videos' quality based on FPS.
https://avi12.com/youtube-auto-hd
GNU General Public License v3.0
235 stars 28 forks source link

[Bug] YTHD popup menu is broken on Firefox 78 #74

Closed oriana808 closed 1 year ago

oriana808 commented 1 year ago

Describe the bug

Screen Shot 2023-03-23 at 8 54 17 PM

Using youtube auto hd with Firefox V78.15 for many months. Worked great. As seen in the screenshot attached, the menu no longer appears functional and the extension no longer works.

This is on an older MacBook Pro. The extension still works on my iMac. Have tried removing and then adding the extension, quitting Firefox, rebooting.

Thanks for any help!

How to reproduce

Not sure what to put here.

Expected behavior

I keep it to 144p because I have very limited bandwidth. When it doesn't work, YouTube keeps changing the resolution in the middle of a video.

What browser(s) can you reproduce the issue on?

Firefox

What OS does it occur on?

Mac ElCapitan

What's the version you're running?

78.15

Additional context

No response

avi12 commented 1 year ago

That's weird, gotta try reproducing it

avi12 commented 1 year ago

I discovered that the issue is the third one: image That's because Firefox <90 does not support it, which is apparently used by Plasmo's Storage module

I can only think of the following solutions:

  1. Upgrade to Firefox 90+
  2. Install the extension manually: youtube_auto_hd_fps-1.6.10.xpi
oriana808 commented 1 year ago

The change must have happened this week, because it worked for months.

Installing the extension manually worked! Thanks so much.

avi12 commented 1 year ago

The downside of installing it manually is that you're basically cut off from updates I was told by a Plasmo maintainer that in the future, the Storage module will ditch the technical limitation, in which case I will do my best to inform you

oriana808 commented 1 year ago

Thanks, really appreciate your help. I can't update Firefox because this is such an old laptop – really only use it to watch YouTube & light browsing.

avi12 commented 1 year ago

I see, that's unfortunate

oriana808 commented 1 year ago

Just an FYI, manually installation only works temporarily. In case anyone else has the same issue. No need to respond. In the meantime I'm praying that the technical limitation is overcome soon :).

avi12 commented 1 year ago

I was told that when you get to the YTHD listing page, you should be able to install the latest version supported by your browser

oriana808 commented 1 year ago

That's where I originally installed from. See attached screenshot. Latest version 1.7.3 works with Firefox 48.0 and later, but not working on Firefox 78.15? I did install version 1.6.11 - will see if that works.

Screen Shot 2023-03-31 at 10 27 33 PM

avi12 commented 1 year ago

That's so weird, it sounds like a bug with the compatibility detection It's worth reporting it to Mozilla