avi12 / youtube-auto-hd

A simple browser extension for changing YouTube videos' quality based on FPS.
https://avi12.com/youtube-auto-hd
GNU General Public License v3.0
235 stars 28 forks source link

[Bug] Entering videos on hover only #85

Closed promers closed 1 year ago

promers commented 1 year ago

Describe the bug

When i open youtube and hover over a video it opens without clicking. On both Chrome and Firefox

How to reproduce

Open youtube and hover mouse over a video

Expected behavior

Hovering mouse over a video should not open it

What browser(s) can you reproduce the issue on?

Chrome

What OS does it occur on?

Windows

What's the version you're running?

1.7.7

Additional context

No response

avi12 commented 1 year ago

I also got this bug and I wasn't sure if it was because of this extension or another Gotta look into it

BlackBeltPanda commented 1 year ago

I'm also experiencing the same behavior with extension version 1.7.5 on Edge version 112.0.1722.39 (Official build) (64-bit) in Windows 11. When opening YouTube or refreshing the page, the first video that's hovered over will be navigated to instead of previewing. After pressing the back button, video previews work as expected again until the page is refreshed.

revmods commented 1 year ago

this appears to be a change to youtube causing this since all old versions of this extension do the same thing. this is on firefox nightly 112.0a1 64-bit, so it cant be the browser since it hasnt been updated since yesterday when the problem didnt exist.

avi12 commented 1 year ago

Upon initial investigation, the suspect line is https://github.com/avi12/youtube-auto-hd/blob/4bd2aa484975035276e6b3ce90050d861347d476/src/cs-helpers/desktop/content-script-desktop.ts#L170-L172

avi12 commented 1 year ago

Yep, that line caused the issue Apparently, I need to worry about the small video preview like image

In terms of the DOM, it behaves the same as the big video player, with the small preview having #inline-preview-player as well

I made a new version, let me know if that fixes it: youtube-auto-hd-fps-1.7.8.zip youtube-auto-hd-fps-1.7.8_adapted_for_firefox.zip

@promers @BlackBeltPanda @revmods

avi12 commented 1 year ago

I'm reopening for now to signal to newcomers that I already pushed a fix

Fantajim commented 1 year ago

Yep, that line caused the issue Apparently, I need to worry about the small video preview like image

In terms of the DOM, it behaves the same as the big video player, with the small preview having #inline-preview-player as well

I made a new version, let me know if that fixes it: youtube-auto-hd-fps-1.7.8.zip youtube-auto-hd-fps-1.7.8_adapted_for_firefox.zip

@promers @BlackBeltPanda @revmods

This version seems to do the trick. Tested on Brave v1.50.118

Awesome work mate.

permissionBRICK commented 1 year ago

Any info on when this will be pushed to the chrome store?

avi12 commented 1 year ago

@permissionBRICK As soon as I'll get an email from CWS that states that the update is live, I will inform anyone who comments on this issue But since I'm not working for the CWS review team, I cannot know for sure; in my experience, it takes between a day or two Though since it's a weekend, in the worst case, it might only be live on Sunday/Monday

mikeazurek commented 1 year ago

Hi, when this fixed version will be available as official update from Chrome Webstore? I see that you've shared a link to this version, but for consistency and safety I'd like it to be updated automatically via official provider

avi12 commented 1 year ago

@mikeazurek If you're looking to be updated automatically, it'll take some time until the update propagates to the entire 100K user base (not sure how much time though) However, you'll also be able to manually update all extensions (via the "Update" button in chrome://extensions)

In terms of when the update will go live, read the comment

F0RMATTED commented 1 year ago

Also experiencing this on W11. I had an older version of the plugin from the opera store (1.7.2 i think). I updated to the latest 1.7.7 from the chrome store. Issue persists. Given that it suddenly appeared on an old version its definitely something from youtube's change.

avi12 commented 1 year ago

@F0RMATTED Yes, though the situation is kind of weird I was included in the A/B testing of the small video previews before entering a video, but I did not have this bug, suggesting that right when rolling the feature to the rest of the users, they made some other changes like adding somewhere an invisible settings button, since the extension looks for it

avi12 commented 1 year ago

Finally, 1.7.8 is live!