search

avi12 / youtube-auto-hd

A simple browser extension for changing YouTube videos' quality based on FPS.
https://avi12.com/youtube-auto-hd
GNU General Public License v3.0
235 stars 28 forks source link

[Bug] Not auto-selecting highest quality if the preferred one doesn't exist #96

Closed swolewizard closed 1 year ago

swolewizard commented 1 year ago

Is your feature request related to a problem? Please describe

Hey there! I'm loving your YouTube extension, but I have a small issue I'd like to address. Currently, if I select a quality that doesn't exist for the video I'm watching, the extension doesn't do anything. It would be awesome if it could automatically choose the next highest quality available. For example, if I set the extension to 1440p but the video's highest quality is 1080p, it should automatically select 1080p. Thanks for considering my suggestion!

Is it a change to the extension's functionality or to the pop-up settings page?

Extension's functionality

If the latter, please propose a new design on Figma or describe it as detailed as possible

No response

Additional context

No response

avi12 commented 1 year ago

That's how the extension should behave by default https://github.com/avi12/youtube-auto-hd/blob/b018fb531ecdb1be6aae29a61467bc72befc4d7a/src/cs-helpers/desktop/content-script-desktop.ts#L102-L105

avi12 commented 1 year ago

What browser are you on? Are you using the latest version, 1.7.10?

swolewizard commented 1 year ago

I'm using Chrome Using version: 1.7.10

When I set my preferred quality to 1440p or above and open a video without those quality settings, the extension does nothing Like this: First

But if I change the quality on the extension with the video currently open, It'll then automatically choose the next highest quality available Like this: Second

avi12 commented 1 year ago

That's peculiar Please click the settings button and take a screenshot

swolewizard commented 1 year ago

Which settings did you want

avi12 commented 1 year ago

I need to see the settings menu

swolewizard commented 1 year ago

Not sure which settings menu you're referring to, I'll send all I can think of

setting1 setting2 setting3

avi12 commented 1 year ago

Thanks, I only needed the 3rd screenshot :) That's very weird indeed So if I understand correctly, when you first load the video, the video quality stays on Auto?

swolewizard commented 1 year ago

That's correct

avi12 commented 1 year ago

Can you try to sideload the ext locally?

swolewizard commented 1 year ago

Unless the quality I've selected in the extension exists, then it correctly switches to 1440p for example

swolewizard commented 1 year ago

Can you try to sideload the ext locally?

no idea how todo this even reading all that

avi12 commented 1 year ago

Can you contact me via Discord so I can guide you on how? avi12#4269

swolewizard commented 1 year ago

Reached out to @avi12 on Discord and found out that the problem I was experiencing was due to a conflicting extension called Looper for YouTube. Removing this extension resolved the issue. Currently, I've kept Looper for YouTube disabled so I can continue using the extension. I was informed that @avi12 will investigate and work on a hotfix to ensure compatibility between the two extensions. Really looking forward to the hotfix and appreciate your assistance!

avi12 commented 1 year ago

Sadly the issue isn't easily fixable and the possible solution is to awkwardly keep changing the quality until one extension "gives up" Better contact Looper's developer to ask him make the auto HD functionality toggleable