avi12 / youtube-auto-hd

A simple browser extension for changing YouTube videos' quality based on FPS.
https://avi12.com/youtube-auto-hd
GNU General Public License v3.0
235 stars 28 forks source link

[Feature request] Indication of status. #97

Closed 54m4d closed 1 year ago

54m4d commented 1 year ago

Is your feature request related to a problem? Please describe

Hi!

When the toggle Extension is on is turned off, it can be challenging to determine whether the extension is actually on or off without clicking and checking the pop-up. This is because there is no indication outside the pop-up.

To improve the user experience, I suggest modifying the extension icon to transition from red to a dark or gray color, effectively "turning off its light" when the Extension is on toggle is switched off. This visual change would clearly indicate that the extension is inactive without requiring users to access the pop-up to verify its status.

I think implementing this small adjustment will greatly enhance the overall user experience.

I look forward to your response.

Is it a change to the extension's functionality or to the pop-up settings page?

Extension's functionality

If the latter, please propose a new design on Figma or describe it as detailed as possible

No response

Additional context

No response

avi12 commented 1 year ago

This is an interesting feature, sounds simple enough to implement

54m4d commented 1 year ago

Great!

Thanks for your attention :)

avi12 commented 1 year ago

Let me know if this works for you: youtube-auto-hd-fps-1.7.11.zip

avi12 commented 1 year ago

Does it mean that it works?

54m4d commented 1 year ago

Sorry, i was writing the comment then i got a call and had to go out.

The functionality works smoothly, however, it is important to remember to reload the page after toggling on/off for the changes to take effect. Without reloading, no action will occur.

Not sure if it's a good idea to add a small reminder telling the user to reload the page each time the toggle is switched?

avi12 commented 1 year ago

No need to reload at all When you toggle on the extension using the switch, it will change the video quality immediately, without any reload

54m4d commented 1 year ago

What if you toggle it off and click another video in the same page, does the quality change to auto without reloading?

avi12 commented 1 year ago

Yes

54m4d commented 1 year ago

That's not what happened in my test, but let me try it again

avi12 commented 1 year ago

WAit you're right, just tested and it applied the quality change anyway Lemme look into it

54m4d commented 1 year ago

Yep, i tried it again and it doesn't change, we have to reload the page, but there's nothing wrong with reloading the page as long as we get a small reminder about doing it, otherwise we will be wondering why we still have that 1080p when the extension is already toggled off 😁

avi12 commented 1 year ago

My goal is to deliver a smooth user experience :) I will continue debugging and upload here an updated version to let you test it out 😁

54m4d commented 1 year ago

Amazing :)

avi12 commented 1 year ago

Let me know if it works: youtube-auto-hd-fps-1.7.11.zip

54m4d commented 1 year ago

This one seems to be working perfectly, looks like it's ready to be pushed to CWS :)