[Bug] - YT Channel Icon

Lucasark commented 6 months ago

Describe the bug

I don't know if it has solution, but sometime when a new channel started couting time it save wrong icon like this:

Wrong:

Right:

How to reproduce

Starting new time

Expected behavior

Save right icon

What browser(s) can you reproduce the issue on?

Chrome

What OS does it occur on?

macOS

What's the extension version you're running?

3.0.3

Make sure the bug wasn't reported before

[X] I'm the first one to report it

Make sure that YouTube Time Manager is the only extension running on YouTube

[X] The issue still persists after disabling any other YouTube extension

Additional context

No response

avi12 commented 6 months ago

I noticed that it's happening during the development but i have no idea why I have to dig into it

Lucasark commented 6 months ago

Another point, I think you need update the icon when it re-starting counting, because the icon channel can be changed in times

avi12 commented 6 months ago

There is a bug fix in the making and it will hopefully solve all of these issues Basically, my fix is to periodically override the channel icons

Lucasark commented 5 months ago

There is a bug fix in the making and it will hopefully solve all of these issues Basically, my fix is to periodically override the channel icons

What is the period of refresh?

avi12 commented 5 months ago

2 hours (arbitrary time selection)

avi12 commented 5 months ago

Try out this version, with a refresh period of 2 minutes: youtube-time-manager-3.0.13.zip

Lucasark commented 5 months ago

Not yet!

Years:

Week:

Maybe, just to test, create a "Sync Button", where we can force update icons

avi12 commented 5 months ago

Added youtube-time-manager-3.0.13.zip

Lucasark commented 5 months ago

Added youtube-time-manager-3.0.13.zip

I tried several times, ...refresh page...click and wait minutes... but nothing happend

avi12 commented 5 months ago

It's just a button that you were supposed to click and wait for a bit. Not refresh or anything Regardless, it's very weird because the periodic updating the algorithm worked for me Can you export the data so I can have real data to work with?

avi12 commented 5 months ago

I made a version where the "Sync channel pictures" gives a better indicator of when the job is finished: youtube-time-manager-3.0.13.zip

Instructions:

Click the button
It disables itself
When the job finishes, the button is reenabled again and the channel pictures should automatically be updated. No need to refresh the page

Lucasark commented 5 months ago

I made a version where the "Sync channel pictures" gives a better indicator of when the job is finished: youtube-time-manager-3.0.13.zip

Instructions:

Click the button

It disables itself

When the job finishes, the button is reenabled again and the channel pictures should automatically be updated. No need to refresh the page

Yes!!! 🎉🎉🎉🎉🎉

Maybe just better UI haha, but worked!

avi12 commented 5 months ago

The goal for the picture updating is to run in the background without the user's intervention

Lucasark commented 5 months ago

The goal for the picture updating is to run in the background with the user's intervention

Another point is that is taking around 4min to do this, just to note

avi12 commented 5 months ago

It barely occurs to me, but if you say that it typically occurs after 4 minutes, I'll update the interval accordingly

avi12 commented 5 months ago

Let me know if this version works better: youtube-time-manager-3.0.13.zip

Lucasark commented 5 months ago

Let me know if this version works better: youtube-time-manager-3.0.13.zip

I FINALLY found one easy way to reproduce, just open one video but when that page is loading go to another yt page video, doing this, it always set the icon with last page and not with new one.

https://github.com/avi12/youtube-time-manager-feedback/assets/31750882/d2ff1d24-745e-4511-8fcd-c6994eb5caec

Just to test, can you enable "loading" , "red icon" just to to know that is on process of sync and "green icon" that is finish? Or maybe a log in console

avi12 commented 5 months ago

I FINALLY found one easy way to reproduce, just open one video but when that page is loading go to another yt page video, doing this, it always set the icon with last page and not with new one.

Huh, it shouldn't behave like this, sounds like a serious bug What should happen in practice is that when navigation occurs, the extension fetches the video and channel data of the new URL

Or maybe a log in console

I added a console log of the active URL: youtube-time-manager-3.0.13.zip

avi12 commented 5 months ago

For faster communications, feel free to get in touch with me on Discord

avi12 / youtube-time-manager-feedback