aviabird / gringotts

A complete payment library for Elixir and Phoenix Framework
https://hexdocs.pm/gringotts/Gringotts.html
MIT License
481 stars 53 forks source link

Fix "cyclomatic_complexity" issue in lib/mix/new.ex #158

Closed pkrawat1 closed 5 years ago

pkrawat1 commented 6 years ago

Function is too complex (CC is 11, max is 9).

https://codeclimate.com/github/aviabird/gringotts/lib/mix/new.ex#issue_5adc7bc78bb7620001000040

barthr commented 5 years ago

I would like to do this one if possible!

ashish173 commented 5 years ago

@barthr yes please, this is still open and waiting to be picked.

barthr commented 5 years ago

Cool! I'm working on a PR which fixes some more credo errors in that particular file, I will submit it in a few hours!

barthr commented 5 years ago

I opened a PR which fixes these warnings, there is one code check which fails, but I think that it's not relevant to the PR. @ashish173

ashish173 commented 5 years ago

Fixed in #182