aviabird / gringotts

A complete payment library for Elixir and Phoenix Framework
https://hexdocs.pm/gringotts/Gringotts.html
MIT License
481 stars 53 forks source link

Release v1.1.1-rc #172

Closed oyeb closed 6 years ago

oyeb commented 6 years ago

The release candidate does some much-needed spring cleaning! wind_face Gringotts is now totally (compile-time) warning free (upto elixir 1.6.5) :yay:

Core

Remove our implementaion of the Gringotts.Money protocol as ex_money implements (and tests!) it for us. Updated various docs and cleaned up some code smell.

Gateways

  1. Refactor Paymill, makes it much more readable and also completes all the pending functionality.
  2. Remove/Deprecate Wirecard as it does not meet the standards of this library.

Checklist

codecov-io commented 6 years ago

Codecov Report

Merging #172 into master will increase coverage by 19.17%. The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #172       +/-   ##
===========================================
+ Coverage   58.15%   77.33%   +19.17%     
===========================================
  Files          14       14               
  Lines         466      375       -91     
===========================================
+ Hits          271      290       +19     
+ Misses        195       85      -110
Impacted Files Coverage Δ
lib/gringotts/gateways/cams.ex 93.75% <ø> (ø) :arrow_up:
lib/gringotts/gateways/monei.ex 97.95% <ø> (ø) :arrow_up:
lib/gringotts.ex 100% <ø> (ø) :arrow_up:
lib/gringotts/gateways/authorize_net.ex 97.56% <ø> (ø) :arrow_up:
lib/gringotts/gateways/global_collect.ex 100% <ø> (ø) :arrow_up:
lib/gringotts/money.ex 0% <ø> (-70%) :arrow_down:
lib/gringotts/gateways/trexle.ex 100% <ø> (ø) :arrow_up:
lib/gringotts/gateways/stripe.ex 0% <0%> (ø) :arrow_up:
lib/gringotts/gateways/paymill.ex 100% <100%> (+100%) :arrow_up:
test/support/fake_money.ex 87.5% <87.5%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb4b19a...4f12f1f. Read the comment docs.