mandarvaze commented 4 years ago

@ashish173 @pkrawat1 I think the link needs to point to https://hex.pm/packages/gringotts/1.1.1-rc instead of generic https://hex.pm/packages/gringotts, since the image text shows v1.1.1-rc

szTheory commented 4 years ago

I think it just pulls the latest entry from the Versions section on the Hex.pm page

mandarvaze commented 4 years ago

@szTheory The latest release is 1.1.0 (and 1.1.1 being rc is not pulled unless explicitly asked for)

But I think what you are suggesting makes sense, otherwise with each released README will need to be updated.

codecov[bot] commented 4 years ago

Codecov Report

Merging #184 into dev will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #184   +/-   ##
=======================================
  Coverage   77.39%   77.39%           
=======================================
  Files          14       14           
  Lines         376      376           
=======================================
  Hits          291      291           
  Misses         85       85

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc36ebc...02ca430. Read the comment docs.

mandarvaze commented 4 years ago

@szTheory Thanks for your contribution. This PR is finally merged :)

aviabird / gringotts

README fix Hex.pm badge link #184

Codecov Report