Closed arjun289 closed 5 years ago
Merging #456 into develop will decrease coverage by
0.03%
. The diff coverage is75%
.
@@ Coverage Diff @@
## develop #456 +/- ##
===========================================
- Coverage 77.86% 77.82% -0.04%
===========================================
Files 174 174
Lines 2128 2138 +10
===========================================
+ Hits 1657 1664 +7
- Misses 471 474 +3
Impacted Files | Coverage Δ | |
---|---|---|
...s/snitch_core/lib/core/data/schema/tax/tax_zone.ex | 100% <ø> (ø) |
:arrow_up: |
apps/snitch_core/lib/core/data/model/zone/zone.ex | 65.78% <0%> (-3.66%) |
:arrow_down: |
...ps/snitch_core/lib/core/data/model/tax/tax_rate.ex | 100% <100%> (ø) |
:arrow_up: |
...ps/snitch_core/lib/core/data/model/tax/tax_zone.ex | 100% <100%> (ø) |
:arrow_up: |
...e/lib/core/data/schema/tax/tax_rate_class_value.ex | 85.71% <83.33%> (-14.29%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4dc2523...a1b337f. Read the comment docs.
Why?
Admin should be able to create new tax zones from the admin panel and modify settings for the same. Also, the tax rates for a tax zone should be configurable from the admin panel.
This change addresses the need by:
Comments
tax_rate_class_values
schema, I have to populate the changesetdata
withtax_class
andtax_class_id
if the changes containtax_class_id
. This was done becausetax_rate_class_values
is being handled usingcast_assoc
intax_rate
schema and, these values are required to render the UI properly.[delivers#163283477]
Checklist
credo
and compile-time warnings.