Closed jyotigautam closed 5 years ago
Merging #468 into develop will decrease coverage by
0.07%
. The diff coverage is55.55%
.
@@ Coverage Diff @@
## develop #468 +/- ##
===========================================
- Coverage 79.1% 79.03% -0.08%
===========================================
Files 175 176 +1
Lines 2202 2208 +6
===========================================
+ Hits 1742 1745 +3
- Misses 460 463 +3
Impacted Files | Coverage Δ | |
---|---|---|
apps/snitch_core/lib/core/application.ex | 100% <ø> (ø) |
:arrow_up: |
...s/snitch_core/lib/core/domain/order/transitions.ex | 42.39% <0%> (ø) |
:arrow_up: |
apps/snitch_core/lib/core/data/model/images.ex | 95.65% <100%> (+0.19%) |
:arrow_up: |
...s/snitch_core/lib/core/tools/mailer/mail_worker.ex | 25% <25%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7e5c107...4c6d4a5. Read the comment docs.
Why?
To send the email asynchronously to prevent breaking the order checkout flow.
This change addresses the need by:
Adding a worker under the supervisor to send order confirmation mails in the background.
delivers #163724078
Checklist
credo
and compile-time warnings.