aviacommerce / avia

open source e-commerce framework
https://aviacommerce.netlify.app/
MIT License
529 stars 113 forks source link

Add to cart fix #470

Closed jyotigautam closed 5 years ago

jyotigautam commented 5 years ago

Why?

To fix failure while adding line items to cart when inventory tracking is disabled.

This change addresses the need by:

Checking whether the inventory tracking is enabled or diabled for a given product before it's presence in the stock.

delivers #163724078

Checklist

codecov[bot] commented 5 years ago

Codecov Report

Merging #470 into develop will increase coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #470      +/-   ##
==========================================
+ Coverage    79.02%   79.1%   +0.08%     
==========================================
  Files          175     175              
  Lines         2198    2202       +4     
==========================================
+ Hits          1737    1742       +5     
+ Misses         461     460       -1
Impacted Files Coverage Δ
...ps/snitch_core/lib/core/domain/stock/quantifier.ex 91.66% <100%> (+4.16%) :arrow_up:
..._core/lib/core/data/model/general_configuration.ex 72.72% <0%> (+9.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 848b809...d10e45d. Read the comment docs.