aviacommerce / avia

open source e-commerce framework
https://aviacommerce.netlify.app/
MIT License
529 stars 113 forks source link

One product_review per user #476

Closed Jeshan7 closed 5 years ago

Jeshan7 commented 5 years ago

Why?

This change addresses the need by:

In rating.ex(factory)

Created a migration for altering the product_reviews table Now user_id column is present in the snitch_product_reviews table Added test cases in the product_reviews schema

[delivers #163942461]

Checklist

codecov[bot] commented 5 years ago

Codecov Report

Merging #476 into develop will decrease coverage by 0.63%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #476      +/-   ##
===========================================
- Coverage    80.25%   79.62%   -0.64%     
===========================================
  Files          176      176              
  Lines         2218     2218              
===========================================
- Hits          1780     1766      -14     
- Misses         438      452      +14
Impacted Files Coverage Δ
...core/lib/core/data/schema/review/product_review.ex 100% <100%> (ø) :arrow_up:
.../snitch_core/lib/core/data/model/product_review.ex 51.61% <0%> (-45.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 54d264f...5567dc8. Read the comment docs.

ashish173 commented 5 years ago

We don't need this at the moment. @Jeshan7 thanks!