avian2 / ec3k

Use rtl-sdr to receive EnergyCount 3000 transmissions
https://pypi.python.org/pypi/ec3k/
GNU General Public License v3.0
18 stars 7 forks source link

accept frequency as argument. print state as json #4

Closed molobrakos closed 8 years ago

molobrakos commented 8 years ago

Accept frequency as optional argument to script. Output state updates as json for easy processing

avian2 commented 8 years ago

Thanks for your contribution. However, I will not accept this pull request: It changes the output unconditionally to JSON, breaking the script for anyone that depends on the existing format. Also, directly pulling arguments from sys.argv makes it hard to add any other arguments in the future.

I would be happy to accept a similar pull request that would use argparse for proper command line handling. That way the script could accept, for example, --freq N and --json arguments.