search

avian2 / unidecode

ASCII transliterations of Unicode text - GitHub mirror
https://pypi.python.org/pypi/Unidecode
GNU General Public License v2.0
517 stars 62 forks source link

localise transcription #30

Closed wanneut closed 5 years ago

wanneut commented 5 years ago

If you translate German umlaute by removing the diaeresis it look very uncommon and ugly to German users. Some seem even offended when transcription is used wrong. See also: https://www.thegermanz.com/how-germans-feel-umlauts-aou/ But transcribe ö with oe is wrong in Turkish. So I used locales to transcribe right. Its a different from the perl behavior and needs the "locale"-packet but I think its better that way.

avian2 commented 5 years ago

Thank you for your contribution. However, I will not be accepting this pull request. Please read my blog post where I explain some of the reasons why I do not want to add language-specific transliteration to Unidecode. Also, consider using/contributing to Unihandecode, which is similar to Unidecode and does implement a language parameter.

wanneut commented 5 years ago

Sorry, I haven't seen that you already closed a feature-request for that.