search

aviate-labs / setup-dfx

Set up your GitHub Actions workflow with a specific version of the Internet Computer SDK
Apache License 2.0
18 stars 4 forks source link

Deprecate aviate-labs/setup-dfx #8

Closed viktorkovarik closed 6 months ago

viktorkovarik commented 7 months ago

Hey, I think you should deprecate aviate-labs/setup-dfx in favour to dfinity/setup-dfx.

Since recent release of DFXVM your GH Action is not working anymore and to fix that I had to inject a few additional env variables. In the end I've found out that official dfinity/setup-dfx already exists and it handles the issues.

What I suggest:

q-uint commented 6 months ago

The suggestion to deprecate aviate-labs/setup-dfx just because there's a new tool from the foundation goes against the open-source ethos. Open source is about options, evolution, and community reliance, not just replacing old with new without considering impact. aviate-labs/setup-dfx has served well for over three years, and its existence supports the diverse needs and preferences within the community. Therefore, we're not planning any deprecation based on the arrival of new tools.

viktorkovarik commented 6 months ago

The suggestion to deprecate aviate-labs/setup-dfx just because there's a new tool from the foundation goes against the open-source ethos. Open source is about options, evolution, and community reliance, not just replacing old with new without considering impact. aviate-labs/setup-dfx has served well for over three years, and its existence supports the diverse needs and preferences within the community. Therefore, we're not planning any deprecation based on the arrival of new tools.

Therefore you should fix your tool since it's not working anymore after release of DFXVM. There are some changes which needs to be done in order to make it work.

viktorkovarik commented 6 months ago

Oh my bad, I can see it's already fixed.