aviator-co / av

A command line tool to manage stacked PRs with Aviator

https://aviator.co

MIT License

149 stars 12 forks source link

Prevent `av commit amend` and `av commit create` for merged branches … #318

Closed Brookke closed 2 months ago

Brookke commented 3 months ago

…#312

Todo

[x] add tests
[x] sync branch state before checking

aviator-app[bot] commented 3 months ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Brookke commented 3 months ago

~Unsure how best to test this given it uses the github api. I have at least made sure that the commands pass the tests by not blocking the command if UpdatePullRequestState fails, this also ensures the CLI can be used offline~

aviator-app[bot] commented 3 months ago

FlexReview Summary

There is not enough data in the repository for FlexReview to determine suggested reviewers.

Detailed Breakdown

Author’s expertise score for the modified files: - `cmd/av/commit_amend.go` (0.00) - `cmd/av/commit_create.go` (0.00) See full breakdown of the reviewers on the Aviator webapp.